[release-4.21] CNV-59877: Fix permissions request for NADs#353
Conversation
Add namespace to the useAccessReview hook so it checks namespace-scoped RBAC instead of cluster-level access. Pass the permission result to NADListEmpty so the create button is hidden when the user lacks permission to create NetworkAttachmentDefinitions. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CNV-59877 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
This is an automated cherry-pick of #352
/assign upalatucci